-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devkit): bump compatibility to Nx 19 - 21.x #28243
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d171474. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ba3e29f
to
398bcf0
Compare
398bcf0
to
c88b5fc
Compare
c88b5fc
to
41878da
Compare
03fe7fb
to
5cce313
Compare
250b702
to
e8855e8
Compare
e8855e8
to
b2f7ab6
Compare
b2f7ab6
to
93cad78
Compare
93cad78
to
abd4a3a
Compare
abd4a3a
to
17b621c
Compare
17b621c
to
398663c
Compare
'node:sea', | ||
'node:sqlite', | ||
]); | ||
const experimentalNodeModules = new Set(['node:sqlite']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? If you run with node --experimental-sqlite
then isBuiltin
from node:module
already includes node:sqlite
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes Nx Console starts the daemon and probably won't run with --experimental-sqlite
so this ensure that it's handled regardless of it's passed or not.
import { combineGlobPatterns } from '../../utils/globs'; | ||
|
||
import type { NxPluginV1 } from '../../utils/nx-plugin.deprecated'; | ||
import type { LoadedNxPlugin, NormalizedPlugin } from './internal-api'; | ||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there changes to the V2 public APIs? I see that CreateNodesV2
is slated for removal in v21, and users should be using CreateNodes
instead. Is that part of v20 changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll do this in Nx 21.. because there's not enough time at the moment.
f480850
to
8101b56
Compare
8101b56
to
05c0531
Compare
05c0531
to
d171474
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
BREAKING CHANGE
Current Behavior
@nx/devkit
supports Nx 17 - 20.ExecutorContext.projectGraph
,ExecutorContext.nxJsonConfiguration
, andExecutorContext.projectsConfigurations
is marked as optional becauseExecutorContext
in some versions of Nx did not have them.ExecutorContext.workspace
is marked as optional becauseExecutorContext
in some versions of Nx did not have the above properties which contain the same information.ProjectGraphNode
is deprecated.NxPluginV1.processProjectGraph
was deprecated long ago and there has been a warning since.appRootPath
has been deprecated for a long time.parseTargetString
had a variant that did not take either the project graph or the executor context.readNxJson
has a variant which does not take a tree. This was not clearly deprecated.@nx/
instead of@nrwl
@nrwl/cli
Expected Behavior
@nx/devkit
supports Nx 19 - 21.ExecutorContext.projectGraph
,ExecutorContext.nxJsonConfiguration
, andExecutorContext.projectsConfigurations
is marked as required becauseExecutorContext
in Nx 19+ is guaranteed to have them.ExecutorContext.workspace
is removed because the same information is available in the above propertiesProjectGraphNode
is removed.NxPluginV1
is no more. All plugins should beNxPluginV2
.workspaceRoot
is the replacement forappRootPath
.appRootPath
is removed.parseTargetString
no longer has a variant that did not take either the project graph or the executor context.readNxJson
still has a variant which does not take a tree but it's clearly deprecated to be removed in Nx 21.@nrwl
packages are no more so we don't have to redirect requires anymore.@nrwl/cli
is no more so Nx shouldn't try to get a root install thereRelated Issue(s)
Fixes #