Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional feedback #65

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Additional feedback #65

merged 6 commits into from
Jul 17, 2023

Conversation

upalatucci
Copy link
Collaborator

@upalatucci upalatucci commented Jul 14, 2023 •
edited
Loading

Feedback doc: https://docs.google.com/document/d/1gVZP7ck3D7NhNMgjShyF1TqR5M1TQWvQNDR-x5KE9i0

  • Interfaces types in horizontal rather than vertical (Network raw)
  • Dark mode fixes
  • feature flags in the drawer moved in the bottom
  • fix popover link to the drawer
  • vlan details in the drawer
  • sort ports

image
Screenshot from 2023-07-14 16-51-10

Screenshot from 2023-07-14 17-10-55
Screenshot from 2023-07-14 16-51-38

@openshift-ci openshift-ci bot requested review from hstastna and pcbailey July 14, 2023 15:22
hstastna
hstastna reviewed Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@hstastna hstastna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, mostly nitpicks ;)
Also I think we are missing translation in these places:

  1. Name
  2. IP address
  3. Ports

Aand maybe also here, I am not sure:

  1. LLDP
  2. MTU

PTAL. Thanks! :)

src/views/states/list/components/InterfaceDrawer/InterfaceDrawerDetailsTab.tsx Outdated Show resolved Hide resolved
src/views/states/list/components/InterfacesTypeSection.tsx Outdated Show resolved Hide resolved
src/views/states/list/components/InterfacesTypeSection.tsx Outdated Show resolved Hide resolved
src/views/states/list/components/InterfaceDrawer/InterfaceDrawerDetailsTab.tsx Outdated Show resolved Hide resolved
src/views/states/list/components/InterfaceDrawer/InterfaceDrawerDetailsTab.tsx Outdated Show resolved Hide resolved
@upalatucci
Copy link
Collaborator Author

Thanks @hstastna resolved all the comments

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f14bc45 into nmstate:main Jul 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstastna hstastna hstastna approved these changes

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@hstastna hstastna

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upalatucci @hstastna @openshift-merge-robot