Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify errors #13

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Clarify errors #13

merged 5 commits into from
Nov 29, 2023

Conversation

billdenney
Copy link
Contributor

I was trying to parse a file, but I got an error that didn't indicate the line number of the error. This now shows the line number.

@mattfidler
Copy link
Member

Hi @billdenney

I don't mind the change. However, I actually built this from upstream sources typically, so I don't know if this change would be overwritten anyway.

There is a script that changes upstream to R-specific.

Matt

@mattfidler
Copy link
Member

There is also a possibility it doesn't build anymore because I took care of CRAN issues...

@mattfidler
Copy link
Member

Since this is drifting more from dparser original due to CRAN, I will probably merge this for now.

@mattfidler mattfidler merged commit 3ba54f2 into main Nov 29, 2023
9 checks passed
@mattfidler mattfidler deleted the clarify-errors branch November 29, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants