Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix smoke tests #379

Merged
merged 9 commits into from
Aug 22, 2024
Merged

CI: Fix smoke tests #379

merged 9 commits into from
Aug 22, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Aug 20, 2024

No description provided.

Comment on lines +217 to +219
bimg = nb.load(boldref)
if len(bimg.shape) > 3:
assert len(bimg.shape) == 4 and bimg.shape[3] == 1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be standardized - we can either have the BOLD references be 3D or 4D with time dim of 1. Currently, the desc-hmc is 3D and desc-coreg is 4D. My inclination is just to squeeze into 3D.

cc @effigies @oesteban

@mgxd mgxd merged commit bdf9679 into master Aug 22, 2024
9 checks passed
@mgxd mgxd deleted the ci/fix-smoke branch August 22, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant