Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: swap out remaining load_resources cruft with acres load #373

Closed
wants to merge 1 commit into from

Conversation

scott-huberty
Copy link
Contributor

If i'm understanding https://github.com/nipreps/smriprep/blob/master/smriprep/data/__init__.py

and

nipreps/smriprep@7f4e0df

correctly, I think you missed an instance of load_resources that needs to be changed to load.

When using nibabies dev with the 24.0.0rc release candidate image, this results in an error smriprep has no attribute load_resources

If i'm understanding https://github.com/nipreps/smriprep/blob/master/smriprep/data/__init__.py

and

nipreps/smriprep@7f4e0df

correctly, I think you missed an instance of load_resources that needs to be changed to load
@effigies
Copy link
Member

effigies commented Aug 2, 2024

Try re-fetching the rc0 image. This was addressed in 03098fe.

@scott-huberty
Copy link
Contributor Author

Thx @effigies 🙏

@effigies effigies closed this Aug 3, 2024
@scott-huberty
Copy link
Contributor Author

scott-huberty commented Aug 3, 2024

@effigies - I am working off the master branch by mounting my local copy of nibabies into the docker container. This is why I hit this error despite 03098fe , which was targeted to the docker/24.0.0rc branch.

Currently, the master branch of Nibabies will not work with either the unstable or 24.0.0rc tags on docker hub (xref #372), but I think we should do our best to make sure it does!

Or am I missing something? Is there a reason that you decided to close this?

@effigies
Copy link
Member

effigies commented Aug 3, 2024

I merged the docker/24.0.0rc0 branch into master.

@scott-huberty
Copy link
Contributor Author

scott-huberty commented Aug 3, 2024

Ok I see, this wasn't the case at the time at the time of my comment, hence the confusion.

Typically on projects I've worked on, we close issues on merge of the PR that addressed the issue, (e.g. closes # ... or fixes # ... ), to avoid this type of confusion. I find that approach helpful!

@scott-huberty scott-huberty deleted the fix_bad_attr branch August 3, 2024 16:20
@scott-huberty scott-huberty mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants