Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/docker/24.0.0rc0'
Browse files Browse the repository at this point in the history
  • Loading branch information
effigies committed Aug 3, 2024
2 parents 056a0f2 + 03098fe commit 38fb3fd
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 5 deletions.
32 changes: 32 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
24.0.0 (TBD)
============
This major release includes a substantial refactoring of the pipeline.

One key addition is the addition of the `--level` flag, which can take the arguments minimal, resampling or full. The default is full, which should produce nearly the same results as previous versions. minimal will produce only the minimum necessary to deterministically generate the remaining derivatives. resampling will produce some additional derivatives, intended to simplify resampling with other tools.

The `--derivatives` flag was altered to take arguments in the form `name=/path/to/dir`.
For each directory provided, if a derivative is found - it will be used instead of computing it from scratch. If a derivative is not found, NiBabies will compute it and proceed as usual.

Taken together, these features can allow a dataset provider to run a minimal NiBabies run, targeting many output spaces, while a user can then run a --derivatives run to generate additional derivatives in only the output spaces they need. Another use case is to provide an precomputed derivative to override the default NiBabies behavior, enabling easier workarounds for bugs or experimentation with alternatives.

Another new feature is a dynamic anatomical reference, which is set based on surface reconstruction method or through the `--reference-anatomical` flag. Previously, T1w was the default output space.

Additionally, minor adjustments have been made to MCRIBS surface reconstruction to address failure rates. This is still an on-going investigation, but preliminary results look promising.

This release resolves a number of issues with fieldmaps inducing distortions during correction. Phase difference and direct fieldmaps are now masked correctly, preventing the overestimation of distortions outside the brain. Additionally, we now implement Jacobian weighting during unwarping, which corrects for compression and expansion effects on signal intensity. To disable Jacobian weighting, add `fmap-jacobian` to the `--ignore` argument.

Finally, a new resampling method has been added, to better account for susceptibility distortion and motion in a single shot resampling to a volumetric target space. We anticipate extending this to surface targets in the future.

## 24.0.0rc0 (August 01, 2024)
* RF: Move to fit/apply workflow (#360)
* FIX: nest pathlib import in fix_multi_source_name (#365)
* FIX: Avoid retrieving multiple templates from latest TF (#353)
* ENH: better repr for Derivatives class (#351)
* FIX: Raise informative error if no t1w or t2w found (#347)
* Replace `resource_filename` with `load_data` (#345)
* FIX: Easier pyenv usage (#342)
* Build(deps): Bump urllib3 from 2.0.3 to 2.0.7 (#319)
* Build(deps): Bump pillow from 9.5.0 to 10.0.1 (#317)
* DOC: Use correct argument flag (#338)
* MAINT: Raise minimum to 3.10, bump actions (#337)
* FIX: Catch nonexistent derivatives, clean up subworkflow logic (#336)
* Use fsLR reg sphere for MCRIBS morphometrics resampling (#334)
* FIX: Multiple T2ws, coerce reference to string (#333)

## 24.0.0a1
* MAINT: Update to latest migas API (#326)
Expand Down
4 changes: 2 additions & 2 deletions nibabies/workflows/bold/resampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -571,11 +571,11 @@ def init_bold_fsLR_resampling_wf(
Path to BOLD series resampled as functional GIFTI files in fsLR space
"""
import smriprep
import templateflow.api as tf
from niworkflows.engine.workflows import LiterateWorkflow as Workflow
from niworkflows.interfaces.utility import KeySelect
from niworkflows.interfaces.workbench import VolumeToSurfaceMapping
from smriprep import data as smriprep_data

fslr_density = '32k' if grayord_density == '91k' else '59k'

Expand Down Expand Up @@ -647,7 +647,7 @@ def init_bold_fsLR_resampling_wf(
extension='.surf.gii',
)
]
atlases = smriprep_data.load_resource('atlases')
atlases = smriprep.load_data('atlases')
select_surfaces.inputs.template_roi = [
str(atlases / f'L.atlasroi.{fslr_density}_fs_LR.shape.gii'),
str(atlases / f'R.atlasroi.{fslr_density}_fs_LR.shape.gii'),
Expand Down
11 changes: 8 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
#
# pip-compile --extra=container --output-file=requirements.txt --strip-extras pyproject.toml
#
acres==0.1.0
# via
# nibabies (pyproject.toml)
# niworkflows
# smriprep
annexremote==1.6.5
# via
# datalad
Expand Down Expand Up @@ -212,7 +217,7 @@ nitransforms==23.0.1
# nibabies (pyproject.toml)
# niworkflows
# sdcflows
niworkflows @ git+https://github.com/nipreps/niworkflows.git@master
niworkflows==1.11.0
# via
# nibabies (pyproject.toml)
# sdcflows
Expand Down Expand Up @@ -368,7 +373,7 @@ scipy==1.13.0
# scikit-learn
# sdcflows
# tedana
sdcflows @ git+https://github.com/nipreps/sdcflows.git@master
sdcflows==2.10.0
# via nibabies (pyproject.toml)
seaborn==0.13.2
# via
Expand All @@ -384,7 +389,7 @@ six==1.16.0
# osfclient
# pybtex
# python-dateutil
smriprep @ git+https://github.com/nipreps/smriprep.git@master
smriprep==0.16.0
# via nibabies (pyproject.toml)
sqlalchemy==2.0.31
# via pybids
Expand Down

0 comments on commit 38fb3fd

Please sign in to comment.