More explicit error message when Field Suggestion is (partially) disabled #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: QuentinN42 <[email protected]>
…-query-regex Duplicate query regex
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
fix: double regex
…to fix/double_regexes
Signed-off-by: QuentinN42 <[email protected]>
feat: add backoff
…fication feat: disable ssl verification
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
feat: some rich progress bars
fix: use pathlib to work with any OS
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
This reverts commit 200f43b.
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
iCarossio
changed the title
|
Hi Antoine! It looks like the PR is ready to be merged though you marked it as Draft. Are you planning to add something else or we can merge it? Thank you! |
|
Hello Nikita,Answering from my emails directly and I have sporadic access to the Intern.You’re right we can merge it right now :) Thank you,Antoine Carossio,Sent from iPhoneOn Jul 4, 2023, at 18:57, Nikita Stupin ***@***.***> wrote:
Hi Antoine! It looks like the PR is ready to be merged though you marked it as Draft. Are you planning to add something else or we can merge it? Thank you!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
nikitastupin
approved these changes
Jul 10, 2023
|
Thank you! I've merged to main and published the v2.5.2 with these changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a question that came up multiple times so I made the message more explicit here. Nothing crazy ;)