Fix nightscout crashes after failed APNs delivery #8292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to stop Nightscout crashing if APNs response is not received well from Apple.
|
tested by creating a new image on dockerhub with a sample of NSPro users. Their sites are no longer crashing and are handling the error gracefully, displaying to the user when the problem exists. |
|
@bewest @sulkaharo - I'm not sure who has the correct level of access to merge these PR's. Any Insights? |
|
Looks good, can we move the workflow to a different branch/PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the loop.js file to handle the error more gracefully and display an error message to the user rather than crashing the Nightscout instance.