Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate umitools/group to nf-test #6653

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate umitools/group to nf-test #6653

wants to merge 4 commits into from

Conversation

SPPearce
Copy link
Contributor

No description provided.

@SPPearce SPPearce marked this pull request as ready for review September 16, 2024 20:12
@SPPearce SPPearce requested review from Joon-Klaps and a team as code owners September 16, 2024 20:12
Copy link
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions


}

test("with_umi - bam") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test("with_umi - bam") {
test("with_umi - create only bam") {


}

test("with_umi - tsv") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test("with_umi - tsv") {
test("with_umi - create bam and tsv") {

assertAll(
{ assert process.success },
{ assert snapshot(
process.out.tsv,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
process.out.tsv,
process.out.tsv,
bam(process.out.bam[0][1]).getReadsMD5(),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants