Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2.2] enh: add backend check for download permission for cloud attachements #9739

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 12, 2024

Backport of #9592

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from st3iny and hamza221 June 12, 2024 14:47
@backportbot backportbot bot added enhancement 3. to review skill:backend Issues and PRs that require backend development skills labels Jun 12, 2024
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@hamza221 hamza221 marked this pull request as ready for review June 12, 2024 15:16
@ChristophWurst
Copy link
Member

Pleaes remove the skip ci from the commit messge

@st3iny
Copy link
Member

st3iny commented Jun 14, 2024

PHP linter and static analysis failures seem legit.

@hamza221 hamza221 merged commit f807f18 into stable2.2 Jun 26, 2024
30 checks passed
@hamza221 hamza221 deleted the backport/9592/stable2.2 branch June 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement skill:backend Issues and PRs that require backend development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants