Fix Lost update between last draft and sending a message #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
reviewed
Aug 15, 2023
hamza221
commented
Aug 15, 2023
hamza221
force-pushed
the
fix/local-draft
branch
from
5ac4d7c
to
fb9b3a6
Compare
| ? $message->setType(LocalMessage::TYPE_OUTGOING) | ||
| : $message->setType(LocalMessage::TYPE_DRAFT); | ||
|
|
||
| $message->setType(LocalMessage::TYPE_DRAFT); |
There was a problem hiding this comment.
\OCA\Mail\Controller\DraftsController::create still has the same logic and it is in use
- Compose a new message
- Send it before the first draft
There is a POST to create the draft but it results in implicit conversion to an outbox message.
Expectation is that the draft is created, then converted to an outbox message.
|
The removed test doesn't make sense anymore in DraftServiceTest, because if I didn't make any mistakes or forgot an edge case. LocalMessages will never have type outbox in the draft service |
|
so, ready to get merged? :) |
ChristophWurst
approved these changes
Aug 17, 2023
| @@ -373,54 +373,6 @@ public function testConvertToOutboxMessage(): void { | |||
| $this->draftsService->updateMessage($account, $message, $to, $cc, $bcc, $attachments); | |||
| } | |||
|
|
|||
| public function testConvertToOutboxMessageNoRecipients(): void { | |||
There was a problem hiding this comment.
right, the test makes no sense anymore because we just dropped the implicit conversion 👍
Signed-off-by: hamza221 <[email protected]>
hamza221
force-pushed
the
fix/local-draft
branch
from
a9c698f
to
1d607fd
Compare
|
/backport to stable3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8734