-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Summarize email thread #8653
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,27 +28,35 @@ | |
use OCA\Mail\Exception\ServiceException; | ||
use OCA\Mail\Http\TrapError; | ||
use OCA\Mail\Service\AccountService; | ||
use OCA\Mail\Service\AiIntegrationsService; | ||
use OCP\AppFramework\Controller; | ||
use OCP\AppFramework\Db\DoesNotExistException; | ||
use OCP\AppFramework\Http; | ||
use OCP\AppFramework\Http\JSONResponse; | ||
use OCP\IRequest; | ||
use Psr\Log\LoggerInterface; | ||
|
||
class ThreadController extends Controller { | ||
private string $currentUserId; | ||
private AccountService $accountService; | ||
private IMailManager $mailManager; | ||
private AiIntegrationsService $aiIntergrationsService; | ||
private LoggerInterface $logger; | ||
|
||
|
||
public function __construct(string $appName, | ||
IRequest $request, | ||
string $UserId, | ||
AccountService $accountService, | ||
IMailManager $mailManager) { | ||
IMailManager $mailManager, | ||
AiIntegrationsService $aiIntergrationsService, | ||
LoggerInterface $logger) { | ||
parent::__construct($appName, $request); | ||
|
||
$this->currentUserId = $UserId; | ||
$this->accountService = $accountService; | ||
$this->mailManager = $mailManager; | ||
$this->aiIntergrationsService = $aiIntergrationsService; | ||
$this->logger = $logger; | ||
} | ||
|
||
/** | ||
|
@@ -111,4 +119,40 @@ public function delete(int $id): JSONResponse { | |
|
||
return new JSONResponse(); | ||
} | ||
|
||
/** | ||
* @NoAdminRequired | ||
* | ||
* @param int $id | ||
* | ||
* @return JSONResponse | ||
*/ | ||
public function summarize(int $id): JSONResponse { | ||
try { | ||
$message = $this->mailManager->getMessage($this->currentUserId, $id); | ||
$mailbox = $this->mailManager->getMailbox($this->currentUserId, $message->getMailboxId()); | ||
$account = $this->accountService->find($this->currentUserId, $mailbox->getAccountId()); | ||
} catch (DoesNotExistException $e) { | ||
return new JSONResponse([], Http::STATUS_FORBIDDEN); | ||
} | ||
if (empty($message->getThreadRootId())) { | ||
return new JSONResponse([], Http::STATUS_NOT_FOUND); | ||
} | ||
$thread = $this->mailManager->getThread($account, $message->getThreadRootId()); | ||
try { | ||
$summary = $this->aiIntergrationsService->summarizeThread( | ||
$message->getThreadRootId(), | ||
$thread, | ||
$this->currentUserId, | ||
); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Calling this in a route is risky as it will likely exceed the PHP max execution time. Also, you might want to cache the output. :) |
||
} catch (\Throwable $e) { | ||
$this->logger->error('Summarizing thread failed: ' . $e->getMessage(), [ | ||
'exception' => $e, | ||
]); | ||
return new JSONResponse([], Http::STATUS_NO_CONTENT); | ||
hamza221 marked this conversation as resolved.
Show resolved
Hide resolved
hamza221 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
return new JSONResponse(['data' => $summary]); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @author Hamza Mahjoubi <[email protected]> | ||
* | ||
* | ||
* This code is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License, version 3, | ||
* as published by the Free Software Foundation. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License, version 3, | ||
* along with this program. If not, see <http://www.gnu.org/licenses/> | ||
* | ||
*/ | ||
|
||
namespace OCA\Mail\Service; | ||
|
||
use OCA\Mail\Exception\ServiceException; | ||
use OCP\TextProcessing\IManager; | ||
use OCP\TextProcessing\SummaryTaskType; | ||
use OCP\TextProcessing\Task; | ||
use Psr\Container\ContainerInterface; | ||
use function array_map; | ||
|
||
class AiIntegrationsService { | ||
|
||
/** @var ContainerInterface */ | ||
private ContainerInterface $container; | ||
|
||
|
||
public function __construct(ContainerInterface $container) { | ||
$this->container = $container; | ||
} | ||
/** | ||
* @param string $threadId | ||
* @param array $messages | ||
* @param string $currentUserId | ||
* | ||
* @return null|string | ||
* | ||
* @throws ServiceException | ||
*/ | ||
public function summarizeThread(string $threadId, array $messages, string $currentUserId): null|string { | ||
try { | ||
$manager = $this->container->get(IManager::class); | ||
} catch (\Throwable $e) { | ||
throw new ServiceException('Text processing is not available in your current Nextcloud version', $e); | ||
} | ||
if(in_array(SummaryTaskType::class, $manager->getAvailableTaskTypes(), true)) { | ||
$messagesBodies = array_map(function ($message) { | ||
return $message->getPreviewText(); | ||
}, $messages); | ||
|
||
$taskPrompt = implode("\n", $messagesBodies); | ||
$summaryTask = new Task(SummaryTaskType::class, $taskPrompt, "mail", $currentUserId, $threadId); | ||
$manager->runTask($summaryTask); | ||
|
||
return $summaryTask->getOutput(); | ||
} else { | ||
throw new ServiceException('No language model available for summary'); | ||
} | ||
} | ||
|
||
public function isLlmAvailable(): bool { | ||
try { | ||
$manager = $this->container->get(IManager::class); | ||
} catch (\Throwable $e) { | ||
return false; | ||
} | ||
return in_array(SummaryTaskType::class, $manager->getAvailableTaskTypes(), true); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always set summaries to
no
if llm apis are not available