Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make nested toolbar working for signature editor #8638

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 19, 2023

Before

Screencast.from.2023-07-19.16-00-04.webm

After

Screencast.from.2023-07-19.16-47-05.webm

@kesselb kesselb self-assigned this Jul 19, 2023
@kesselb kesselb added this to the v3.3.0 milestone Jul 19, 2023
@kesselb
Copy link
Contributor Author

kesselb commented Jul 19, 2023

/backport to stable3.2

Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@@ -171,6 +177,10 @@ export default {
updateOpen() {
this.$emit('update:open')
},
handleShowToolbar(element) {
console.debug('handleShowToolbar', element)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@kesselb kesselb force-pushed the focus-trap-ckeditor-signature branch from 9cd8854 to 8c0965c Compare July 20, 2023 16:27
@kesselb kesselb merged commit 69d8952 into main Jul 21, 2023
28 checks passed
@kesselb kesselb deleted the focus-trap-ckeditor-signature branch July 21, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants