Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare editing state on new message modal #8637

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 19, 2023

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

States were removed. Remove/fix the usage in the template

@GretaD
Copy link
Contributor Author

GretaD commented Jul 24, 2023

States were removed. Remove/fix the usage in the template

I was wondering which one was the case, removing or adding the leftovers. I added the leftovers because you added the state it on this PR: https://github.com/nextcloud/mail/pull/7691/files after removing it from Composer component. Just FYI why i kept it. But will remove it again and make it work without it then

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Please revert unrelated changes (around states).

src/components/NewMessageModal.vue Outdated Show resolved Hide resolved
src/components/NewMessageModal.vue Outdated Show resolved Hide resolved
@GretaD GretaD force-pushed the fix/editing-state-message branch from d063e8f to 5fb36a7 Compare July 26, 2023 14:38
@GretaD GretaD requested a review from st3iny July 26, 2023 14:41
@GretaD GretaD merged commit 6c147d6 into main Jul 27, 2023
27 of 28 checks passed
@GretaD GretaD deleted the fix/editing-state-message branch July 27, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants