Add key property to dashboard messages and fix misc errors for emails with empty from array #8489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IchbinkeinReh
changed the title
|
@ChristophWurst sry for asking. Do i have to do anything to get this PR reviewed or did you have no time yet to review the PR? |
| @@ -128,6 +128,7 @@ export default { | |||
|
|
|||
| await Promise.all(inboxes.map(async (mailbox) => { | |||
| const messages = await fetchEnvelopes(mailbox.accountId, mailbox.databaseId, this.query, undefined, 10) | |||
| messages.forEach(message => { message.id = message.databaseId }) | |||
There was a problem hiding this comment.
I don't comprehend why this is necessary. Could you elaborate? nvm it's in #8489 (comment)
ChristophWurst
approved these changes
Jun 28, 2023
…ix misc errors for emails with empty from array Signed-off-by: Patrick Bender <[email protected]>
ChristophWurst
force-pushed
the
fix-4580
branch
from
66e545b
to
b8ac765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4580
this is because DashboardWidget uses field id as key for the v-for and the messages do not have an id field (see https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcDashboardWidget/NcDashboardWidget.vue#L190 )