-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 IMPROVE: don't open first mail by default #6863
Conversation
Sounds like a Vue reactivity bug I've fought before. Not sure how I solved it last time. |
Yes, indeed... |
Okay, some more results: Line 41 in 916e98a
triggers the async action syncInboxes Lines 713 to 715 in 916e98a
which in turn dispatches fetchEnvelopes with query undefinedthis then commits addEnvelope with query being empty/undefined:Lines 467 to 471 in 916e98a
so only at that point, mailbox.envelopeLists actually contains an element with index being an empty string...
My question now is: Is that element of
|
Empty string is the unfiltered envelope list. That would be used when you view your real inbox, not the unified one. The unified inbox consists of three filtered inboxes. The background sync always uses the unfiltered inbox. So on page load there is no list for So that is not a bug and fetching that list on page load is hopefully not necessary.
It is or is not displayed? |
Thanks for the explanation !
On the unified inbox, the placeholder is not displayed initially but only after 30 seconds, once there exists a list for |
friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Thanks a lot for your PR.
@violoncelloCH could you add a screenshot for easier design review? :) What would be great is an emptycontent screen like:
|
@jancborchardt please see attached a preview of your comment and if i understood you right,
|
71a4993
to
88955eb
Compare
Signed-off-by: Jonas Sulzer <[email protected]>
ab70613
to
a7178d1
Compare
…on priority inbox Signed-off-by: Jonas Sulzer <[email protected]>
a7178d1
to
bc97990
Compare
Jan, sorry, it was green, and i just click the merge button. If theres still something to do here, i will push a fixup on Monday 🤦 |
fix #6526
This removes the logic to automatically open the first message of a mailbox
In contrary to #2794, this also doesn't open the first mail, when the current folder is reloaded as this would be unexpected: If I open a mailbox, don't select any mail and click on the same mailbox again I don't want the first message to be opened at that time. (Also the current implementation would've lead to first messages being opened while navigation between mailboxes.)
There is one remaining bug: on the initial load of the priority mailbox,
this.$store.getters.getEnvelopes(this.mailbox.databaseId, this.searchQuery)
returns an empty list even though there are mails in the inbox. ThereforehasEnvelopes
is false and the "No message selected" placeholder isn't displayed. After a few seconds (after the third or fourthsync
request; but I'm not sure that's actually related) thegetEnvelopes
getter suddenly returns the correct answer and the view gets updated. I couldn't find out why this getter isn't working at initial load.Any idea on how to debug this further ?