Fix PGP/MIME sending and viewing #10195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabzm
force-pushed
the
fix-pgp-mime
branch
8 times, most recently
from
6375e4a
to
add510a
Compare
Sending emails that were encrypted using Mailvelope in API-mode require a different handling, because the encrypted cleartext contains MIME-headers. Signed-off-by: Pablo Zmdl <[email protected]>
Provide the ciphertext to the frontend and hand the ciphertext to Mailvelope. Signed-off-by: Pablo Zmdl <[email protected]>
|
This is now ready for review. I don't know if some changes could be done more elegantly, please give me a hint if so. |
st3iny
approved these changes
Oct 6, 2024
| @@ -110,6 +112,9 @@ class LocalMessage extends Entity implements JsonSerializable { | |||
| /** @var int|null */ | |||
| protected $updatedAt; | |||
|
|
|||
| /** @var bool */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var bool */ | |
| /** @var bool|null */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes sending and viewing PGP/MIME encrypted emails (as produced and consumed by Mailvelope in API-mode).
Previously, sent messages were viewable in Mailvelope, too, but all other email programs showed the enclosed mime-headers, because the ciphertext was not properly encapsulated.
Closes #3833 and #9862