Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update incorrect Android API name #18956

Merged

Conversation

cthomas-newrelic
Copy link
Contributor

withBuildVersion does not exist in the Android SDK. The correct method name is withApplicationBuild.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
    A customer reported tis inconsistence through a support call. Misnamed API method. Verified this does not occur with iOS agent docs.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.

  • If your issue relates to an existing GitHub issue, please link to it.

sidekick @ndesai-newrelic

`withBuildVersion` does not exist in the Android SDK. The correct
method name is `withApplicationBuild`.
Copy link

Hi @cthomas-newrelic 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 5739c58
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/670d6cd8593d4e0008516b77
😎 Deploy Preview https://deploy-preview-18956--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jeff-colucci
jeff-colucci previously approved these changes Oct 14, 2024
@jeff-colucci jeff-colucci self-assigned this Oct 14, 2024
@jeff-colucci jeff-colucci added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 14, 2024
jeff-colucci
jeff-colucci previously approved these changes Oct 14, 2024
This could really be removed. We no longer support Android agent
verisons older then 6.0.0.
@cthomas-newrelic
Copy link
Contributor Author

@jeff-colucci I wonder if you could look at another formatting issue? It seems the markdown anchor does not need the "#" label. For example, I see Kotlin [#kotlin] for the Kotlin example. The same applies to other sections.

@jeff-colucci
Copy link
Contributor

@cthomas-newrelic Which areas are you seeing this in? I checked the build preview file and I didn't see anything, but it's completely possible I'm looking in the wrong place

@cthomas-newrelic
Copy link
Contributor Author

@jeff-colucci ok, that's weird. I don't see it now. operator error perhaps. It was in https://docs.newrelic.com/docs/mobile-monitoring/new-relic-mobile/mobile-sdk/set-application-build-number/

@jeff-colucci
Copy link
Contributor

@cthomas-newrelic No problem, sometimes the preview builds are like that. I've re-reviewed and everything looks good so I'm going to go ahead and publish!

@jeff-colucci jeff-colucci merged commit 532c6c1 into newrelic:develop Oct 15, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants