-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update incorrect Android API name #18956
fix: update incorrect Android API name #18956
Conversation
`withBuildVersion` does not exist in the Android SDK. The correct method name is `withApplicationBuild`.
Hi @cthomas-newrelic 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This could really be removed. We no longer support Android agent verisons older then 6.0.0.
@jeff-colucci I wonder if you could look at another formatting issue? It seems the markdown anchor does not need the "#" label. For example, I see |
@cthomas-newrelic Which areas are you seeing this in? I checked the build preview file and I didn't see anything, but it's completely possible I'm looking in the wrong place |
@jeff-colucci ok, that's weird. I don't see it now. operator error perhaps. It was in https://docs.newrelic.com/docs/mobile-monitoring/new-relic-mobile/mobile-sdk/set-application-build-number/ |
@cthomas-newrelic No problem, sometimes the preview builds are like that. I've re-reviewed and everything looks good so I'm going to go ahead and publish! |
withBuildVersion
does not exist in the Android SDK. The correct method name iswithApplicationBuild
.Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
What problems does this PR solve?
A customer reported tis inconsistence through a support call. Misnamed API method. Verified this does not occur with iOS agent docs.
Add any context that will help us review your changes such as testing notes,
links to related docs, screenshots, etc.
If your issue relates to an existing GitHub issue, please link to it.
sidekick @ndesai-newrelic