Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discovery): fix docs related to discovery #18793

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

paologallinaharbur
Copy link
Member

The docs related to autodiscovery had some issues:

  • the syntax was wrong: ${'${discovery.ip}'}
  • the integration example was a mix of Config format v3 and V4 (command: and name of integration not matching binary)

Copy link

Hi @paologallinaharbur 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit cf53c26
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66fa848cebc6b20008179d07
😎 Deploy Preview https://deploy-preview-18793--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 1, 2024
@akristen
Copy link
Contributor

akristen commented Oct 8, 2024

Hi @paologallinaharbur ! Please reach out to the docs hero when this PR is ready for a review and merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants