Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube rewrite #16716

Merged
merged 7 commits into from
Apr 2, 2024
Merged

SonarQube rewrite #16716

merged 7 commits into from
Apr 2, 2024

Conversation

bradleycamacho
Copy link
Contributor

Rewrites the SonarQube integration

@bradleycamacho bradleycamacho added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Mar 28, 2024
@bradleycamacho bradleycamacho self-assigned this Mar 28, 2024
@bradleycamacho bradleycamacho marked this pull request as ready for review March 28, 2024 21:08
Copy link

Hi @bradleycamacho 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 803c65e
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/660aeb4c3015890008b4eb3c
😎 Deploy Preview https://deploy-preview-16716--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradleycamacho bradleycamacho removed the request for review from rhetoric101 March 28, 2024 21:11
Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy + structure is great, so no asks there. I think a few steps should have a bit more detail on the why customers are being asked to do this. I think we can get away with very barebones instructions in other OHIs, as they really have a limited number of installs to work through. Since this one is asking customers to do a little more upfront work, we might want to include how each discrete step relates to SonarQube (especially because there is no 'Install Sonarqube integration' step lol

@bradleycamacho bradleycamacho merged commit c89eae4 into develop Apr 2, 2024
17 checks passed
@bradleycamacho bradleycamacho deleted the sonarqube-rewrite branch April 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants