Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoEnroll feature on frontend #878

Merged

Conversation

giacoliva
Copy link
Contributor

Description

Tenants can ask to join a workspace in which autoEnroll feature is enabled.

Managers can approve join requests.

This PR also fixes minor issues.

Must be merged AFTER #877

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

@giacoliva giacoliva requested a review from a team as a code owner December 22, 2023 14:27
@kingmakerbot
Copy link
Collaborator

Hi @giacoliva. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giacoliva giacoliva force-pushed the go/autoenroll-frontend branch 2 times, most recently from f532556 to 3e12951 Compare January 18, 2024 10:51
@QcFe
Copy link
Collaborator

QcFe commented Jan 18, 2024

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-878 label to your tenant.

@QcFe
Copy link
Collaborator

QcFe commented Jan 18, 2024

@giacoliva if you think we're ready, supposing you also checked everything is alright in case of no autoenrollable workspaces at all, let me know so we can merge.

@giacoliva
Copy link
Contributor Author

giacoliva commented Jan 22, 2024

@giacoliva if you think we're ready, supposing you also checked everything is alright in case of no autoenrollable workspaces at all, let me know so we can merge.

Just checked with no autoenroll features enabled and everything is ok, so I suppose we can merge

@QcFe
Copy link
Collaborator

QcFe commented Jan 22, 2024

/merge

@kingmakerbot kingmakerbot merged commit b5aba7a into netgroup-polito:master Jan 22, 2024
31 checks passed
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants