Implementation for Issue #7 - Add 'use_parent_location' attribute in Ibexa ContentSearchHandler #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'use_parent_location' parameter has been included to extend the ContentSearchHandler. This new boolean attribute modifies the buildParentLocationParameters and isContextual methods, allowing for the parent location to be used as the search parameter if activated. Additionally, necessary wordings have been added to the translation files.
|
Hi @fwoldt ! I will check this out in coming weeks when my workload dies down a bit. For now, please remove all |
…his->contentProvider->provideLocation() doesnt return a location
|
Moin @emodric, thx for your time. I removed the VIP credits and fixed the error that was caused by the test workflows ( getParentLocation of null ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'use_parent_location' parameter has been included to extend the ContentSearchHandler. This new boolean attribute modifies the buildParentLocationParameters and isContextual methods, allowing for the parent location to be used as the search parameter if activated. Additionally, necessary wordings have been added to the translation files.