Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the image regarding the "providers" section. #2925

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Dec 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: #2792

What is the new behavior?

Proposal:

  • Updated illustration( image ) dedicated to "providers"

before:

before-providers

after:

after-providers

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Currently in the "providers" section, the illustration (image) is not updated is still from NestJS v4, when the "providers" were called "Components", reading the documentation of NestJS v4.

@Tony133
Copy link
Contributor Author

Tony133 commented Dec 17, 2023

Note:

Currently I am not sure if it is correct how I edited the image, it is to be evaluated, definitely it is to be updated is so that people understand when they read the section regarding "providers" since NestJS over the years has evolved bringing new features.

@kamilmysliwiec as soon as you find some time, can you give me some indication if the image I modified is correct ? , based on the current version of NestJS? 😅 because honestly it is very confusing since it is still from NestJS v4 😅, so I correct it. 😉

Here is the link for the preview regarding the providers page: https://deploy-preview-2925--docs-nestjs.netlify.app/providers 🔥

P.s. I have also prepared the other illustrations (images) at a better resolution is similar to the providers, if it is okay with you we can update them. 🙂

Have a good week 🙂

@Tony133 Tony133 changed the title fix: update image providers fix: update provider image Dec 17, 2023
@Tony133 Tony133 changed the title fix: update provider image fix: update the image regarding the "providers" section. Dec 17, 2023
@kamilmysliwiec
Copy link
Member

I view "components" as a broader term that can encompass a domain service, a processor, a facade, or any other related entity, which is why it was originally labeled that way in the diagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants