Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(microservices): clarify hybrid application startup #2852

Merged

Conversation

jtimmons
Copy link
Contributor

@jtimmons jtimmons commented Sep 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: #2835

There is currently no documentation on how to deal with an application which starts up multiple microservice servers but does not handle HTTP requests which has led to a couple cases of confusion where people are not properly starting up their application fully (see linked ticket for incidences).

What is the new behavior?

Clarified how to handle a hybrid application which is HTTP+Microservice vs one which is Microservice+Microservice

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

added a note to the microservices section and hybrid application for how to deal
with an application with multiple microservices but no HTTP server
@kamilmysliwiec kamilmysliwiec merged commit ee6360c into nestjs:master Sep 11, 2023
5 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants