Enable raw SQL to be inserted into tagged-template queries #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in sql() function, addressing #120
|
(hold on — there's a problem here) |
pffigueiredo
approved these changes
Dec 17, 2024
| @@ -1,3 +1,5 @@ | |||
| Insert raw text into tagged-template `sql` queries by wrapping with the `sql()` function (issue #120). | |||
There was a problem hiding this comment.
nit: add an "## Unreleased" header to these items
| // composed sql for literal strings (SQL injection risk) | ||
| const func = 'pi()'; | ||
| await sql`SELECT ${sql(func)} AS composed_func_result`; | ||
| await sql`SELECT ${11} AS eleven, ${sql(func)} AS composed_func_result, ${12} AS twelve`; |
There was a problem hiding this comment.
Would it make sense to have a test case with a try... catch... using a "Tagged-template query with parameters" to make sure we are handling that right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable raw SQL strings to be inserted into tagged-template queries by wrapping them in the
sql(...)function, addressing #120.For example:
In this implementation, queries with parameters may not be inserted into other queries.
In principle, we could have tagged-template queries be more generally composable — including queries with parameters.
This would be nice to have, but requires more serious refactoring, since in that case the
ParameterizedQueryobject can't be put together until just before execution (since you don't know what numbers the parameters are going to have).