compute/sql_exporter: Bump max WSS window from 1h -> 3h #10239
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ref neondatabase/cloud#22214.
For larger workloads, 1-hour working set size windows may not be enough to hold the working set size (and so, autoscaling may not have enough information to do a good job scaling LFC). I'm not sure what the right value is, but 3 hours seems like a reasonable increase.
Summary of changes
Concretely, this:
Changes the normal (public) exporter to add a new 3-hour working set size label onto the existing 5-minute, 15-minute, and 1-hour values.
Extends the range on the autoscaling exporter from 1..60 minutes to 1..180 minutes -- keeping the same density, just 3x longer.
I'll try using the compute image produced by this PR on some larger workload before merging, to see if any issues pop up.