Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute/sql_exporter: Bump max WSS window from 1h -> 3h #10239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sharnoff
Copy link
Member

Problem

ref neondatabase/cloud#22214.

For larger workloads, 1-hour working set size windows may not be enough to hold the working set size (and so, autoscaling may not have enough information to do a good job scaling LFC). I'm not sure what the right value is, but 3 hours seems like a reasonable increase.

Summary of changes

Concretely, this:

  1. Changes the normal (public) exporter to add a new 3-hour working set size label onto the existing 5-minute, 15-minute, and 1-hour values.

  2. Extends the range on the autoscaling exporter from 1..60 minutes to 1..180 minutes -- keeping the same density, just 3x longer.


I'll try using the compute image produced by this PR on some larger workload before merging, to see if any issues pop up.

Concretely, this:

1. Changes the normal (public) exporter to add a new 3-hour working set
   size label onto the existing 5-minute, 15-minute, and 1-hour values.

2. Extends the range on the autoscaling exporter from 1..60 minutes to
   1..180 minutes -- keeping the same density, just 3x longer.
@sharnoff sharnoff requested a review from a team as a code owner December 25, 2024 01:31
@sharnoff sharnoff requested a review from kelvich December 25, 2024 01:31
Copy link

github-actions bot commented Dec 25, 2024

7121 tests run: 6824 passed, 0 failed, 297 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (8400 of 26877 functions)
  • lines: 48.0% (66688 of 139059 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8b11e3b at 2024-12-25T04:54:30.906Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants