Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: fix tenant::storage_layer::layer tests #10227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikgrinaker
Copy link
Contributor

Problem

cargo test fails non-deterministically on these tests, because they share global state via LAYER_IMPL_METRICS and then assert on this global state.

Tests really should not share global state, but as a simple hack for now, just reset the global state and serialize the tests.

Summary of changes

Reset LAYER_IMPL_METRICS for each test, and run tests serially.

@erikgrinaker erikgrinaker requested a review from a team as a code owner December 23, 2024 11:50
Copy link

7095 tests run: 6796 passed, 0 failed, 299 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 31.3% (8413 of 26889 functions)
  • lines: 48.0% (66729 of 139096 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7475bf4 at 2024-12-23T12:55:25.314Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant