pageserver: fix tenant::storage_layer::layer
tests
#10227
+96
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cargo test
fails non-deterministically on these tests, because they share global state viaLAYER_IMPL_METRICS
and then assert on this global state.Tests really should not share global state, but as a simple hack for now, just reset the global state and serialize the tests.
Summary of changes
Reset
LAYER_IMPL_METRICS
for each test, and run tests serially.