cargo: build with frame pointers #10226
Draft
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Frame pointers are often disabled by default (depending on the architecture), since this frees up an additional CPU register. However, this makes stack unwinding more difficult, and it often has to rely on DWARF debug information which is very slow. With continuous profiling, cheaper stack unwinding will likely be a net win, and allow us to use higher sampling resolution.
This may cause some performance loss (TODO: benchmark), but typically <1% on 64-bit architectures. aarch64 architectures (used for Pageservers) also typically mandate the use of a dedicated frame pointer register, so this has no effect.
Resolves #10224.
Summary of changes
Enable frame pointers in all builds.