Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update neon_fixtures.py - remove logs #10219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update neon_fixtures.py - remove logs #10219

wants to merge 2 commits into from

Conversation

areyou1or0
Copy link

@areyou1or0 areyou1or0 commented Dec 20, 2024 •
edited
Loading

We need to remove this line to prevent aws keys exposing in the public s3 buckets

@areyou1or0
Update neon_fixtures.py - Security Incident
93007c0 
this line is exposing the AWS credentials which was raised in a security incident. We need to remove this line to prevent more aws keys exposing in the public s3 buckets

https://github.com/neondatabase/neon/blob/9c53b41245e3aecba30c2e05df4eeabe45fd39ac/.github/actions/allure-report-store/action.yml#L4 is the workflow that uploads reports to S3 -> using OIDC
@areyou1or0 areyou1or0 changed the title Update neon_fixtures.py - Security Incident Update neon_fixtures.py - remove logs Dec 20, 2024
@areyou1or0 areyou1or0 enabled auto-merge December 20, 2024 13:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

7121 tests run: 6824 passed, 0 failed, 297 skipped (full report)

Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 31.2% (8399 of 26877 functions)
  • lines: 48.0% (66680 of 139059 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
5905c71 at 2024-12-20T15:38:52.127Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-masterov a-masterov a-masterov approved these changes

@potin86 potin86 potin86 approved these changes

@mickael-carl mickael-carl mickael-carl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@areyou1or0 @mickael-carl @a-masterov @potin86