neonvm-runner: Small cleanups #1185
Open
+1,257
−1,268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like these were swapped out in c693804 / neondatabase/neonvm#5, without stating where they came from. I don't see a reason we need to keep our own copies of them, so let's just switch back to the docker versions.
Basically, instead of 'go build path/to/main.go', we should instead write 'go build path/to/*.go' -- otherwise, adding new files alongside main.go will result in unexpected errors about items not being found.
main.go is huge, and this seems like a reasonable place to make a cut.
We probably should remove this anyways, but in the meantime, having it all collected in one file keeps that out of the way, and should make it easier to remove later.
No changes to the coverage.
HTML Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at trying to implement some changes to what neonvm-runner puts in the ISO 9660 filesystem, and quickly began hitting #1184, so decided to make some changes to fix that.
The commits are basically just what the subject messages say.
It's worth noting that these changes are kind of only surface-level; I think there's deeper structural changes that we should make so neonvm-runner can be easier to maintain and extend, but I'm not entirely sure what that should look like, and just breaking it up into separate files seemed less objectionable.