neonvm-controller: Remove support for DIMM slots #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  1 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Ensure Administrative Boundaries Between Resources | ...ller/deployment.yaml | View in code |
Omrigan
reviewed
Sep 19, 2024
sharnoff
force-pushed
the
sharnoff/neonvm-deprecate-dimmslots
branch
from
16c5309 to
a252d05
Compare
sharnoff
force-pushed
the
sharnoff/neonvm-deprecate-dimmslots
branch
from
d0d4865 to
7decf05
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
HTML Report |
|
todo: Need to update this PR after recent changes. |
Also, explicitly set them to use spec.memoryProvider = DIMMSlots, to contrast with the existing VirtioMem versions.
This is part 1 of 2 for removing DIMM slots support and completing our transition to using virtio-mem instead (ref #1060). With this change, neonvm-controller will always assume that VMs are using virtio-mem. The only checks exist at the top of the reconcile functions, making sure that this is indeed the case. The fields still exist in the CRD (although the're marked as deprecated), so that rollback of this change is still sound. neonvm-runner also retains support for both memory providers, so that custom neonvm-runner images continue to work for at least one version across the change.
sharnoff
force-pushed
the
sharnoff/neonvm-deprecate-dimmslots
branch
from
7decf05 to
9035287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of 2 for removing DIMM slots support and completing our transition to using virtio-mem instead (ref #1060).
With this change, neonvm-controller will always assume that VMs are using virtio-mem. The only checks exist at the top of the reconcile functions, making sure that this is indeed the case.
The fields still exist in the CRD (although they're marked as deprecated), so that rollback of this change is still sound.
neonvm-runner also retains support for both memory providers, so that custom neonvm-runner images continue to work for at least one version across the change.