Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema validation for job if functions #2446

Conversation

ChristopherHX
Copy link
Contributor

Fixes #2444

  • Add Tests

Copy link
Contributor

github-actions bot commented Sep 10, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.3s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.15s
✅ REPOSITORY secretlint yes no 1.01s
✅ REPOSITORY trivy-sbom yes no 0.46s
✅ REPOSITORY trufflehog yes no 5.32s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

mergify bot commented Sep 10, 2024

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Sep 10, 2024
pkg/schema/schema.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.69%. Comparing base (5a80a04) to head (71fe493).
Report is 108 commits behind head on master.

Files with missing lines Patch % Lines
pkg/schema/schema.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2446       +/-   ##
===========================================
+ Coverage   61.56%   76.69%   +15.12%     
===========================================
  Files          53       62        +9     
  Lines        9002     8177      -825     
===========================================
+ Hits         5542     6271      +729     
+ Misses       3020     1343     -1677     
- Partials      440      563      +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Sep 10, 2024
pkg/schema/schema.go Outdated Show resolved Hide resolved
@nektos-ci nektos-ci merged commit 4143017 into master Sep 10, 2024
10 checks passed
@nektos-ci nektos-ci deleted the 2444-act-0266-error-workflow-is-not-valid-spellingyml-line-112-column-5-failed-to-match-job-factory-line-119-column-9-unknown-function-call-success branch September 10, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants