New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB in luigi2 #30

Open

OetkenPurveyorOfCode wants to merge 1 commit into nakst:main from OetkenPurveyorOfCode:main

OetkenPurveyorOfCode commented Sep 1, 2024

Fixes signed integer overflow by using unsigned defined constants.

.\luigi2 (beta).h:4138:23: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior .\luigi2 (beta).h:4138:23
...

Avoids passing a passing a nullptr to memove:

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior .\luigi2 (beta).h:2041:84
.\luigi2 (beta).h:3114:44: runtime error: applying zero offset to null pointer
...

Removes the unsused variable width on line 3198.


          Fix UB in luigi2

ea56c19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet