Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support batchRegisterInstance of nacos2.x for develop branch #336

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Oct 30, 2023

try to fix #307 at develop branch

  • support dubbo application level instantces sychronization (dubbo.application.metadata-type=remote or local) between nacos2 clusters
  • support synchronization from consul, eureka, zookeeper to nacos2.x based on batchRegisterInstance method
  • fix some logical bugs

@zrlw zrlw changed the title support ephemeral instances synchronization support ephemeral instances batch synchronization Nov 2, 2023
@zrlw zrlw changed the title support ephemeral instances batch synchronization support batchRegisterInstance of nacos2.x for develop branch Nov 2, 2023
pom.xml Outdated
<spring-boot.version>2.5.14</spring-boot.version>
<spring-cloud.version>2020.0.2</spring-cloud.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<zookeeper.version>3.4.9</zookeeper.version>
<curator.version>4.1.0</curator.version>
<mockito.version>1.10.19</mockito.version>
<nacos-client.verison>1.4.2</nacos-client.verison>
<nacos-client.verison>2.3.0</nacos-client.verison>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading from 1.4.2 to 2.3.0 will result in compatibility issues with 1.x cluster synchronization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nacos client 2.x provided batch registration interfaces, so this version only support nacos2.x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we suggest use a new branch for nacos 2.x support, e.g. nacos-2.x to support nacos 2.x client.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we suggest use a new branch for nacos 2.x support, e.g. nacos-2.x to support nacos 2.x client.

i don't have permission to create a new branch.

@zrlw
Copy link
Contributor Author

zrlw commented Jan 9, 2024

088088cc031081c2e304
这个review没有提交,pending状态的review只有提交者自己可见啊
我这里回复一下:
dubbo3服务级别的实例包含两部分内容,一部分是原来的instance,另一部分是元数据中心,客户端访问dubbo服务不仅需要注册中心返回instance,还需要元数据中心返回服务元数据。当nacos作为注册中心时,默认元数据中心就是nacos注册中心自带的配置管理服务,这个PR只实现了注册中心自带配置管理服务的服务实例元数据同步。

@luoxiner
Copy link

Can we add configuration synchronization to support Dubbo meta migration?
Support for configuration synchronization will cover more scenarios and it looks more generic.

@zrlw
Copy link
Contributor Author

zrlw commented May 15, 2024

Can we add configuration synchronization to support Dubbo meta migration? Support for configuration synchronization will cover more scenarios and it looks more generic.

maybe this pr is just meeting our needs. you might provide a new PR for configuration synchronization?

@zrlw zrlw force-pushed the batchRegisterForDevelopBranch branch from 7a17358 to 59e0c31 Compare May 16, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants