Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Aliyun ram AuthPlugin #245

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: Support Aliyun ram AuthPlugin #245

merged 1 commit into from
Sep 12, 2024

Conversation

luoxiner
Copy link
Contributor

Support Aliyun ram auth plugin.
#244

CherishCai
CherishCai reviewed Sep 12, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
CherishCai
CherishCai reviewed Sep 12, 2024
View reviewed changes
src/api/props.rs Outdated Show resolved Hide resolved
@CherishCai
Copy link
Collaborator

Looks So Good!

@CherishCai
Copy link
Collaborator

可以本地执行些指令优化代码通过 CI

  • Build with cargo build
  • Test with cargo test
  • 请 cargo clippy --all 根据提示优化代码
  • 请 cargo fmt --all 格式化代码再提交

@CherishCai CherishCai added the enhancement New feature or request label Sep 12, 2024
@CherishCai CherishCai added this to the 0.4 milestone Sep 12, 2024
@CherishCai
Copy link
Collaborator

CherishCai commented Sep 12, 2024 •
edited
Loading

似乎少了 builder 模式的 enabled_auth_plugin_aliyun()
类似 ConfigServiceBuilder.enable_auth_plugin_http() NamingServiceBuilder.enable_auth_plugin_http()

@luoxiner
Copy link
Contributor Author

@CherishCai 非常感谢你的review， 提出的commont都已经解决了

@CherishCai CherishCai merged commit f8922e1 into nacos-group:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CherishCai CherishCai CherishCai left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@luoxiner @CherishCai