Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tonic and prost #233

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Upgrade tonic and prost #233

merged 1 commit into from
Jul 10, 2024

Conversation

thynson
Copy link
Contributor

@thynson thynson commented Jul 9, 2024 •
edited
Loading

Depends on #232

@thynson thynson force-pushed the upgrade-tonic-and-prost branch 3 times, most recently from 24920c1 to 6265f41 Compare July 9, 2024 17:45
@CherishCai
Copy link
Collaborator

CherishCai commented Jul 10, 2024 •
edited
Loading

先前这样做，是因为构建是否不用下载 protobuf 编译环境，让用户很简单就能在本地跑 demo。
若改成这样，是需要用户本地有 protobuf 编译环境的，使用成本较高，建议还是保留原样。
版本升级没问题

@CherishCai CherishCai self-requested a review July 10, 2024 00:47
CherishCai
CherishCai approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@CherishCai CherishCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CherishCai CherishCai merged commit 4b7f21b into nacos-group:main Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CherishCai CherishCai CherishCai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thynson @CherishCai