Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support alpine stretch, reduce nacos-server image size #65

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

fdiskbrain
Copy link

@fdiskbrain fdiskbrain commented Nov 22, 2019

Purpose

  • Reduce nacos-server docker image size
  • Support more arch without change main docker image

Support alpine

  • Add Dockerfile-alpine
  • Add package bash
  • Remove ENV JAVA_HOME JAVA from dockerfile
  • Refine Docker file reduce layer

Support stretch

  • Add Dcokerfile-stretch
  • Remove ENV JAVA_HOME JAVA from dockerfile
  • Refine Docker file reduce layer

Startup scripts modify

  • Alpine/stretch image ENV JAVA_HOME provider by base image. java bin is in system PATH.
  • Add ${java} default value java to build/bin/docker-startup.sh,

Testing

@paderlol paderlol self-requested a review November 22, 2019 15:28
@wilsonwu wilsonwu mentioned this pull request Apr 11, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fdiskbrain
❌ Rong zhu(FB)


Rong zhu(FB) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants