-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow applying further filters after DoctrineProxyFilter #175
Conversation
Hello, sorry to ping you @mnapoli, I have errors on prod env while copying Doctrine entities because of that issue :( |
Hi! To be honest, I am not sure about the impact of this change, and whether it could cause backward compatibility issues. Introducing a new (copied) class sounds like a big addition too. Is there any other solution we can do to increase confidence here? What is your own degree of confidence on this change? Usually I'm fine trying things out, but this package is used very very widely, I'd like to avoid taking too much risk. |
Hello :) As you stated, this package is very used and even if I'm confident with the fix on itself, it might indeed have side effects. Working on the 2.0 version might be a solution (the fix is already there) but I'm totally fine with what you said here #173 (comment) What I can propose is to only add the ChainableFilter interface in this PR and I revert the DoctrineProxyFilter to his initial Filter interface. What do you think ? |
Hello again @mnapoli I have finally some time to work on this PR and I have 2 proposals:
What do you think? |
I think the second option sounds good 👍 |
7316d2e
to
0de0336
Compare
Updated the PR with the second option. |
Thanks! |
Backport PR #101 and #133 (based issue #98) on version 1, after discussions on #173.
I continue to think that being unable to apply 2 filters with Doctrine Proxy is a bug.
If you think it's a BC break, I can create a new DoctrineProxyFilter class and depreciate the existing class, but I'm not sure how to name it.