-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Palette Properties Dialog Accessibility #25038
base: master
Are you sure you want to change the base?
Fix Palette Properties Dialog Accessibility #25038
Conversation
It should be possible to do it for the spinboxes as well. Of course, that's slightly more complicated because they are in a Repeater, but that's easy to solve: you can use
|
Thanks for the suggestion @cbjeukendrup. I tried this approach earlier, but after navigating to the first spin box (i.e. Width), it's not possible to navigate to the other spin boxes using the arrow keys, which leads to issue #20515 |
As a workaround, one can use the left/right arrows instead of up/down, and sometimes one needs to press Esc to be able to move to the next one. |
@cbjeukendrup Ok, Updated. |
} | ||
|
||
ButtonBox { | ||
width: parent.width | ||
|
||
buttons: [ ButtonBoxModel.Cancel, ButtonBoxModel.Ok ] | ||
|
||
navigationPanel.section: root.navigationSection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we set the order too, so that it doesn't collide with the navigationPanel
of the other items?
I found that the "palette cell properties" dialog (right-click on a specific palette cell to find it) also doesn't have navigation yet. Since that dialog is so similar, it might make sense to fix that one too in this PR. |
Resolves: #18880
I believe these changes improve the accessibility of this dialog to some extent, except for the spin box.