Name MusicXML files, types and methods consistently #25037
+1,533
−1,540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
reviewed
Oct 4, 2024
There was a problem hiding this comment.
I hate to nit-pick on everything, but note that in existing code we've usually written Xml (as in XmlStreamReader), and also Json rather than JSON, Midi rather than MIDI. So for the sake of consistency, one could argue that MusicXml is preferable. But I won't insist on this; if you prefer MusicXML that's also fine.
|
No - you're right, please continue nitpicking! Sorted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clears up the varied use of
musicXML,musicXml,mxmletc. and replaces them all withMusicXML(ormusicXMLif at the start of a method name).This affects all names except for private variable names and parameters.