Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH#24998: cannot use shortcut (show-corrupted-measures) #25011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jojo-Schmitz
Copy link
Contributor

Resolves: #24998

bool showCorruptedMeasures = true;
#else
bool showCorruptedMeasures = false;
#endif
Copy link
Contributor Author

@Jojo-Schmitz Jojo-Schmitz Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure about this, having it set to true seems a sane default for debug and non-debug builds, esp. as that setting doesn't seen to get saved accross sessions, so needs to get enabled time and time again (in non-debug builds).

An alternative or additional option might be to have a a checkbox in the 'Corrupt score' dialog, to enable this setting right when it is needed, or even enable it there without asking the user in case of a corrupted score, or even each time a corrution is found.

Ideas welcome ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a "stretch goal", we could do the following:

  • Indeed, make this option true by default
  • Add a command to (re-)check for corruptions (current workaround is to wait until Autosave runs, because that also checks for corruptions, but does not warn about them in the UI, and it is questionable whether Autosave is supposed to run the corruption check at all)
  • For optimisation, set a member variable in the Score whether it contains any corrupted measures; if that's false, no need to iterate over all measures to find corrupted ones

Copy link
Contributor Author

@Jojo-Schmitz Jojo-Schmitz Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The true by default is dead easy, I'll do it right way
Not sure how to go about adding such a command (will look into it), but indeed autosave shouldn't run that check or report them right away.
The optimization won't help much, as more corruption might have crept in after the last check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the "try by default"

@Jojo-Schmitz Jojo-Schmitz force-pushed the show-corrupted-measures branch 2 times, most recently from 4abdf23 to 6ba7955 Compare October 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot use shortcut (show-corrupted-measures)
2 participants