Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove arrayref dep #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jamyw7g
Copy link

@Jamyw7g Jamyw7g commented Dec 2, 2022

Reduce third-party dependency.

@mxinden
Copy link
Member

mxinden commented Dec 6, 2022

Can you expand on the rational here? While it might reduce compile times, I would much rather depend on a well established external crate with anything containing unsafe code.

@Jamyw7g
Copy link
Author

Jamyw7g commented Dec 10, 2022

In my opinion, there are two reasons, one is to reduce the use of macros, and the other is that the use of third-party crate require to audit. So I think we can implement some simple functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants