Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #199 #200

Merged
merged 6 commits into from
Sep 14, 2024
Merged

fix issue #199 #200

merged 6 commits into from
Sep 14, 2024

Conversation

roumano
Copy link
Contributor

@roumano roumano commented Feb 29, 2024

  • Use a list with name and mode (optional) attribut
  • Use a loop_contorl / loop_var for better read the playbook
  • Change only the permission of /etc/mysql/debian.cnf from 0644 to 0600 on all debian but it's can easily update to other OS

Description

Actually the permission is hardcoded to 0644 for all files.

Related Issue

fix issue #199

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Use a list with name and mode (optional) attribut
- Use a loop_contorl / loop_var for better read the playbook
- Change only the permission of /etc/mysql/debian.cnf from 0644 to 0600 on all debian but it's can easily update to other OS
@eRadical
Copy link
Collaborator

eRadical commented May 2, 2024

@roumano can you please try to resolve conflicts?

@roumano
Copy link
Contributor Author

roumano commented May 3, 2024

@roumano can you please try to resolve conflicts?

Yes no problem, it's done

@eRadical
Copy link
Collaborator

I still get "This branch cannot be rebased due to conflicts"

@roumano
Copy link
Contributor Author

roumano commented May 11, 2024

@eRadical , Hi, it's strange, on github it's say "This branch has no conflicts with the base branch"
are you sure, you trying to make the MR on master branch ?

but as i don't have write access, i also see this : "Only those with write access to this repository can merge pull requests."

@eRadical
Copy link
Collaborator

Found it: The master branch in your fork is 9 commits behind.

Sync the fork 1st.
Then rebase permission_file branch.

@roumano
Copy link
Contributor Author

roumano commented May 11, 2024

Found it: The master branch in your fork is 9 commits behind.

Sync the fork 1st. Then rebase permission_file branch.

Please retry now

@roumano
Copy link
Contributor Author

roumano commented Jul 7, 2024

@eRadical , the issue "This branch cannot be rebased due to conflicts" is fixed for your side or not ?

@eRadical
Copy link
Collaborator

eRadical commented Jul 8, 2024

@roumano I have » "This branch cannot be rebased due to conflicts"

@roumano
Copy link
Contributor Author

roumano commented Jul 8, 2024

@roumano I have » "This branch cannot be rebased due to conflicts"

Please try again, if it's failed again, i will create a complete new (and clean) branch , ...

Copy link

stale bot commented Sep 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 10, 2024
@eRadical
Copy link
Collaborator

@roumano - can you try again to rebase? As I think this is valuable.

@stale stale bot removed the wontfix label Sep 10, 2024
@eRadical eRadical assigned eRadical and roumano and unassigned eRadical Sep 10, 2024
@roumano
Copy link
Contributor Author

roumano commented Sep 14, 2024

Sync fork done, please try again

@eRadical
Copy link
Collaborator

eRadical commented Sep 14, 2024

In vars/debian.yml you didn't quote 0600 that's why it's failing for debian 10 and ubuntu 18.

@eRadical
Copy link
Collaborator

For debian 12... the failure is old and I believe is from somewhere else.

@roumano
Copy link
Contributor Author

roumano commented Sep 14, 2024

In vars/debian.yml you didn't quote 0600 that's why it's failing for debian 10 and ubuntu 18.

Thx for the information, i've fixed it.

@eRadical
Copy link
Collaborator

@elcomtik - LGTM, thoughts?

@elcomtik
Copy link
Collaborator

LGTM

@eRadical eRadical merged commit 2804a6c into mrlesmithjr:master Sep 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants