Deduplicate GitHub issues in activities.json #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantek
requested changes
Oct 15, 2024
There was a problem hiding this comment.
The mozPositionIssue updates all look correct (and finer-grained) to me. Thanks for doing this.
The only nit I noticed (unchanged from before, but worth fixing while touching these since separate issues with descriptions got created) is a couple of instances of:
"mozPositionDetail": "A welcome successor to XBL!",
Could these be replaced with something slightly more specific to the technology being reviewed? (just as the issue numbers are more specific now)
|
What should they say? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087