Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 'CustomJsonEncoder' to handle more NumPy types #3757

Closed
wants to merge 1 commit into from

Conversation

PromiseFru
Copy link
Collaborator

@PromiseFru PromiseFru commented Oct 25, 2023

No description provided.

@PromiseFru
Copy link
Collaborator Author

PromiseFru commented Oct 25, 2023

After making these changes locally, which resolved the ZeroDivisionError: division by zero for me, and running the test_trainer locally passed, but it fails on the CI. I'll mark the PR as a draft to investigate further.

@PromiseFru PromiseFru marked this pull request as draft October 25, 2023 15:09
@PromiseFru PromiseFru closed this Oct 26, 2023
@PromiseFru PromiseFru deleted the issue-3754 branch October 26, 2023 13:13
@AngieMeliss
Copy link

Hi, may I ask why you closed the PR?
some lines were helping to fix a bug I was having, I was going to make that suggestion

@PromiseFru
Copy link
Collaborator Author

Hi, may I ask why you closed the PR? some lines were helping to fix a bug I was having, I was going to make that suggestion

Hello @AngieMeliss, I was working on other issues, and since the updates I made weren't the relevant solution for the issue I was targeting, it required me to delve further into the cause of the failing test. I may be slow on that since I'm focusing on another issue, so I closed it so someone else can work on it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants