Issue #3692: Modified methods to use zstdmt binary

[PromiseFru]

Closes #3692

Hello @marco-c @suhaibmujahid,

I've made changes to the zstd_decompress and extract_tar_zst methods. They now use the zstdmt binary instead of the zstd binary for decompression tasks.

Please, I wish to find out if this change is needed just for decompression tasks, or should I update other methods like zstd_compress and create_tar_zst that use the zstd binary for compression.

Additionally, I noticed the presence of the zstandard Python library, alongside the use of the zstd binary for certain tasks. I'm curious about why both are used when they seem to perform similar tasks.

[suhaibmujahid]

Thank you for the PR, @PromiseFru! Could you please test/execute the change code locally to confirm that it is working?

Closes #3692

Please add the linking keyword in the description

Please, I wish to find out if this change is needed just for decompression tasks, or should I update other methods like zstd_compress and create_tar_zst that use the zstd binary for compression.

The scope of the issue concerns the decompression tasks only.

Additionally, I noticed the presence of the zstandard Python library, alongside the use of the zstd binary for certain tasks. I'm curious about why both are used when they seem to perform similar tasks.

Originally zstandard was used everywhere but it was replaced to improve the performance.

[PromiseFru]

Thank you for the PR, @PromiseFru! Could you please test/execute the change code locally to confirm that it is working?

Closes #3692

Please add the linking keyword in the description

Please, I wish to find out if this change is needed just for decompression tasks, or should I update other methods like zstd_compress and create_tar_zst that use the zstd binary for compression.

The scope of the issue concerns the decompression tasks only.

Additionally, I noticed the presence of the zstandard Python library, alongside the use of the zstd binary for certain tasks. I'm curious about why both are used when they seem to perform similar tasks.

Originally zstandard was used everywhere but it was replaced to improve the performance.

Hello @suhaibmujahid

I ran the tests that focused on the methods I had updated, and all of them passed. I have attached their logs below:

pytest -vk "test_zstd_compress_decompress"

test_zstd_compress_decompress.txt

pytest -vk "test_extract_db_zst"

test_extract_db_zst.txt

[suhaibmujahid]

Thank you, @PromiseFru! We have now extract_tar_zst() still not tested. Could you execute it locally or add a test for it?

BTW. If you add a test, it will run automatically on our CI.

[PromiseFru]

Thank you, @PromiseFru! We have now extract_tar_zst() still not tested. Could you execute it locally or add a test for it?

BTW. If you add a test, it will run automatically on our CI.

Hello @suhaibmujahid, I appreciate your feedback. I've included a test_create_extract_tar_zst for testing the create_tar_zst and extract_tar_zst methods since they didn't have tests. I would appreciate any additional feedback. 🙏🏾. Also, I ran the test locally, and it passed.

pytest -vk "test_create_extract_tar_zst"

test_create_extract_tar_zst.txt

[suhaibmujahid]

Thank you, @PromiseFru! LGTM!

[marco-c]

Couldn't create_tar_zst also use zstdmt?

[suhaibmujahid]

Couldn't create_tar_zst also use zstdmt?

I advised in #3703 (comment) to only change the decompressing functions to stay in the scope of issue #3692. I will create a separate issue for that.

[marco-c]

Thanks!