Minor fixes for cache manager and processor #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some comments, removes some unused things, and tidies up how the processes are launched. This also renames some of the script files to follow a better convention. run_service_* is the script that the entrypoint.sh script runs. Each one is a service: webapp, processor, crontabber. The run_service_processor.sh script runs honcho which runs two processes: run_processor.sh and run_cache_manager.sh. run_verify_reqs.sh is a utility script like test.sh and lint.sh that we run in CI, so I renamed it to verify_reqs.sh
paul-mclendahand has configuration in pyproject.toml, so we don't need it in setup.cfg, too.
smarnach
approved these changes
May 16, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some comments, removes some unused things, and tidies up how the processes are launched.
This also renames some of the script files to follow a better convention.
run_service_*is the script that theentrypoint.shscript runs. Each one is a service: webapp, processor, crontabber.The
run_service_processor.shscript runs honcho which runs two processes:run_processor.shandrun_cache_manager.sh.run_verify_reqs.shis a utility script liketest.shandlint.shthat we run in CI, so I renamed it toverify_reqs.sh.