-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHEP-2] UI Created to Split a Single Campaign into Multiple Campaigns #268
base: main
Are you sure you want to change the base?
[SHEP-2] UI Created to Split a Single Campaign into Multiple Campaigns #268
Conversation
…aign-into-multiple-campaigns
…aign-into-multiple-campaigns
Hey @akhan-mozilla how to run the app locally? I've run Have you seen this before? |
dashboard/src/data/campaigns.ts
Outdated
@@ -14,6 +18,31 @@ export const useGetCampaignsQuery = () => { | |||
|
|||
return getCampaigns; | |||
}; | |||
|
|||
export const useSplitCampaignMutation = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan on defining return types for some of these functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already have types defined for all the mutate return functions used in there, we don't have to define the type here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
dashboard/src/data/campaigns.ts
Outdated
toast.error("An unexpected error occurred"); | ||
} | ||
}, | ||
onSuccess: (data) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define the type for data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the data returned in onSuccess
here isn't being used, so I removed it. I'll check for any other missing return types and add them.
It seems the |
…aign-into-multiple-campaigns
This doesn't seem to be related to the Boostr products since you are creating the campaigns. I just added a quick update; could you please try creating the new campaign again? |
Can we please add the Jira story to the PR title so once we squash and merge it we can keep track of it? |
@akhan-mozilla Just popping in to make a quick reminder to manually run (Just to be clear, not saying you should address any lint issues that aren't related to this PR, there are some on |
…aign-into-multiple-campaigns
…aign-into-multiple-campaigns
References
SHEP-2
Problem Statement
With the automatic creation of a child campaign when new booster deals are imported, we need a UI that allows to split a single campaign into multiple campaigns.
Proposed Changes
Split Campaign Form Added to Allow Users to Split a Single Campaign into Multiple Campaigns.
Verification Steps
Visuals
Split_Campaign_feature.mov