add goimports to the linter #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges
force-pushed
the
goimports-in-ci
branch
2 times, most recently
from
109c119
to
18f42b6
Compare
jmhodges
force-pushed
the
goimports-in-ci
branch
from
18f42b6
to
5fa4977
Compare
I noticed my editor was making import ordering changes in recent code (like in GH-1000). To avoid that kind of churn, this patch adds the fairly standard `goimports` tool to golangci-lint. I then ran `golangci-lint run --fix`. The comment changes are changes to godoc where the "#" format for section headings was added in go 1.19 (see <https://tip.golang.org/doc/comment>) and were created when running `--fix`.
jmhodges
force-pushed
the
goimports-in-ci
branch
from
5fa4977
to
21c8f3c
Compare
bhearsum
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my editor was making import ordering changes in recent code
(like in GH-1000).
To avoid that kind of churn, this patch adds the fairly standard
goimportstool to golangci-lint.I then ran
golangci-lint run --fix.The comment changes are changes to godoc where the "#" format for
section headings was added in go 1.19 (see
https://tip.golang.org/doc/comment) and were created when running
--fix.