Allow toggling performance overlay while streaming #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add back menu to send sepcial keys. E.g. close fullscreen while using yuzu.
Changes: * Include toggle keyboard action in game menu * Add generic game input device abstraction (which can be implemented by all kind of input devices) * Show input device game menu options * Implement for controller to provide mouse emulation selection
Changes: * Add withGameFocus option to game menu option to run the given runnable after alert dialog has been closed and the game has focus again. * use game focus option for on screen keyboard and toogle mouse
This adds an option into the GameMenu allowing us to turn the performance overlay on/off without needing to exit and go into the settings.
|
See also this idea, which has some overlap: https://ideas.moonlight-stream.org/posts/314/consistent-toggleable-performance-stats-overlay-from-controller |
|
Hello @tlusk , it's possible to have apk with last with updated code v12.1 ? Thanks :) |
|
Would be a fantastic addition to master repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option into the GameMenu allowing us to turn the
performance overlay on/off without needing to exit and go into the
settings.
This MR builds upon #1171 and requires that MR to be merged first.
After #1171 is merged i'll rebase this against master to make the history clean.
CC: @kmreisi